water - marj #38
Open
water - marj #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Jan 17, 2021
There was a problem hiding this comment.
Nice work Marj, you have a fully functional Exquisite corpse game and you got all the tests to pass. Well done.
You didn't have to use our suggested prop-types or use the tests, but if you used different props, you should have adjusted the prop types. Prop types help document your components and explain to other devs how to use your components.
The tests are good guidelines to help make sure your components perform as expected. They're also not too hard to get working as they interact with the components like a use would, for the most part.
|
|
||
| // creat list of all submissions | ||
| const finalPoem = props.submissions.map(sentence => { | ||
| return <p>{sentence}</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Question for instructors
-I disregarded the propTypes (and test because I saw something about this on slack) for this assignment, and I hope that is okay. I think I still learned what I was meant to, but if not, I will redo the assignment. I kind of approached this like media ranker with trying to match the original as close as possible, and it made it a much more interesting for me to be honest.
-wave-0.1 was the optional refactor, and I feel like I came close, but could not figure out a good was to include value={form fields.___}. If you have time, I would love to get feedback on this :)
Thank you for all you do~!
Reflection